On Tue, Oct 17, 2023 at 7:23 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: > > On Tue, Oct 17, 2023 at 8:45 AM Robert Haas <robertmh...@gmail.com> wrote: > >> +1. I think this is more annoying than the status quo ante. > > > Although ... I do think it's spared me some rebasing pain, and that > > does have some real value. I wonder if we could think of other > > alternatives. > > An alternative I was thinking about after reading your earlier email > was going back to the status quo ante, but doing the manual tree-wide > reindents significantly more often than once a year. Adding one at > the conclusion of each commitfest would be a natural thing to do, > for instance. It's hard to say what frequency would lead to the > least rebasing pain, but we know once-a-year isn't ideal.
That seems like the best alternative we have. The old status quo did occasionally allow code with indentation that *clearly* wasn't up to project standards to slip in. It could stay that way for quite a few months at a time. That wasn't great either. -- Peter Geoghegan
