On Fri, Oct 27, 2023 at 8:06 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > +1 for > > > s/003_upgrade_logical_replication_slots.pl/003_upgrade_logical_slots.pl > > > and s/invalid_logical_replication_slots.txt/invalid_logical_slots.txt. > > +1. The proposed file name sounds reasonable. > > Agreed. So, how about 003_upgrade_logical_slots.pl or simply > 003_upgrade_slots.pl? > > Why not simply oldpub/sub/newpub or old_pub/sub/new_pub?
+1 for invalid_logical_slots.txt, 003_upgrade_logical_slots.pl and oldpub/sub/newpub. With these changes, the path name is brought down to ~220 chars. These names look good to me iff other things in the path name aren't dynamic crossing MAX_PATH limit (260 chars). C:/tools/nmsys64/home/pgrunner/bf/root/HEAD/pgsql.build/testrun/pg_upgrade/003_upgrade_logical_slots/data/t_003_upgrade_logical_slots_newpub_data/pgdata/pg_upgrade_output.d/20231026T112558.309/invalid_logical_slots.txt -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
