On Thu, Nov 2, 2023 at 2:36 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Thu, Nov 2, 2023 at 11:32 AM Michael Paquier <mich...@paquier.xyz> wrote: > > > > On Thu, Nov 02, 2023 at 02:32:07PM +1100, Peter Smith wrote: > > > On Thu, Nov 2, 2023 at 2:25 PM Peter Smith <smithpb2...@gmail.com> wrote: > > >> Checking this patch yesterday prompted me to create a new thread > > >> questioning the inconsistencies of the "GUC names in messages". In > > >> that thread, Tom Lane replied and gave some background information [1] > > >> about the GUC name embedding versus substitution. In hindsight, I > > >> think your original message was fine as-is, but there seem to be > > >> examples of every kind of style, so whatever you do would have some > > >> precedent. > > >> > > >> The patch v4 LGTM. > > > > > > To clarify, all the current code LGTM, but the patch is still missing > > > a guc_hook test case, right? > > > > - NULL, NULL, NULL > > + check_max_slot_wal_keep_size, NULL, NULL > > > > FWIW, I am +-0 with what you are proposing here. I don't quite get > > why one may want to enforce this specific GUC at upgrade. > > > > I also can't think of a good reason to do so but OTOH, I can't imagine > all possible scenarios. As this setting is invalid or can cause > problems, it seems people favor preventing it. Alvaro also voted in > favor of preventing it, so we are considering to proceed with it > unless more people think otherwise. >
Now, that Michael also committed another similar change in commit 7021d3b176, it is better to be consistent in both cases. So, either we should have check hooks for both parameters or follow another route where we always forcibly override these parameters (which means the user-provided values for these parameters will be ignored) in pg_upgrade and document it. Yet another simple way is to simply document the current behavior. In the future, if we see users complain about this or have use cases to use these parameters during an upgrade, we can accordingly try to adapt the behavior. Thoughts? -- With Regards, Amit Kapila.
