On 01.11.23 12:12, Aleksander Alekseev wrote:
Hi,
Hmm. I think maybe we should fix the behavior of
GetDataDirectoryCreatePerm() to be more consistent between Windows and
non-Windows. This is usually the first function a program uses on the
proposed data directory, so it's also responsible for reporting if the
data directory does not exist. But then on Windows, because the
function does nothing, those error scenarios end up on quite different
code paths, and I'm not sure if those are really checked that carefully.
I think we can make this more robust if we have
GetDataDirectoryCreatePerm() still run the stat() call on the proposed
data directory and report the error. See attached patch.
Yep, that would be much better.
Attaching all three patches together in order to make sure cfbot is
still happy with them while the `master` branch is evolving.
Assuming cfbot will have no complaints I suggest merging them.
Done, thanks.
