On Tue, Nov 7, 2023 at 3:14 PM Hayato Kuroda (Fujitsu) <kuroda.hay...@fujitsu.com> wrote: > > Dear hackers, > > PSA the patch to solve the issue [1]. > > Kindly Peter E. and Andrew raised an issue that delete_old_cluster.sh is > generated in the source directory, even when the VPATH/meson build. > This can avoid by changing the directory explicitly. >
Hi Kuroda-san, Thanks for the patch. I reproduced the bug, then after applying your patch, I confirmed the problem is fixed. I used the VPATH build ~~~ BEFORE t/001_basic.pl .......... ok t/002_pg_upgrade.pl ..... ok t/003_logical_slots.pl .. ok All tests successful. Files=3, Tests=39, 128 wallclock secs ( 0.05 usr 0.01 sys + 12.90 cusr 7.43 csys = 20.39 CPU) Result: PASS OBSERVE THE BUG Look in the source folder and notice the file that should not be there. [postgres@CentOS7-x64 pg_upgrade]$ pwd /home/postgres/oss_postgres_misc/src/bin/pg_upgrade [postgres@CentOS7-x64 pg_upgrade]$ ls *.sh delete_old_cluster.sh ~~~ AFTER # +++ tap check in src/bin/pg_upgrade +++ t/001_basic.pl .......... ok t/002_pg_upgrade.pl ..... ok t/003_logical_slots.pl .. ok All tests successful. Files=3, Tests=39, 128 wallclock secs ( 0.06 usr 0.01 sys + 13.02 cusr 7.28 csys = 20.37 CPU) Result: PASS CONFIRM THE FIX Check the offending file is no longer in the src folder [postgres@CentOS7-x64 pg_upgrade]$ pwd /home/postgres/oss_postgres_misc/src/bin/pg_upgrade [postgres@CentOS7-x64 pg_upgrade]$ ls *.sh ls: cannot access *.sh: No such file or directory Instead, it is found in the VPATH folder [postgres@CentOS7-x64 pg_upgrade]$ pwd /home/postgres/vpath_dir/src/bin/pg_upgrade [postgres@CentOS7-x64 pg_upgrade]$ ls tmp_check/ delete_old_cluster.sh log results ====== Kind Regards, Peter Smith. Fujitsu Australia
