On 2023-Nov-07, Michael Paquier wrote: > On Tue, Nov 07, 2023 at 10:38:04AM +0100, Jelte Fennema-Nio wrote: > > In pipeline mode after queuing a message to be sent we would flush the > > buffer if the size of the buffer passed some threshold. The only message > > type that we didn't do that for was the Flush message. This addresses > > that oversight. > > > > I noticed this discrepancy while reviewing the > > PQsendSyncMessage/PQpipelinePutSync patchset. > > Indeed, it looks a bit strange that there is no flush if the buffer > threshold is reached once the message is sent, so your suggestion > sounds right. Alvaro?
I agree, and I intend to get this patch pushed once the release freeze is lifted. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "The Gord often wonders why people threaten never to come back after they've been told never to return" (www.actsofgord.com)