On Fri, Nov 3, 2023 at 6:53 PM Etsuro Fujita <etsuro.fuj...@gmail.com> wrote: > On Thu, Nov 2, 2023 at 10:20 PM Daniel Gustafsson <dan...@yesql.se> wrote: > > > On 2 Nov 2023, at 13:40, Etsuro Fujita <etsuro.fuj...@gmail.com> wrote: > > > Attached is a small patch for that: s/heapam_visibility.c/snapmgr.c/. > > > > No objections to the patch, the change is correct. However, with git grep > > and > > ctags and other ways of discovery I wonder if we're not better off avoiding > > such references to filenames which are prone to going stale (and do from > > time > > to time). > > Agreed. As XidInMVCCSnapshot() is an extern function, such a tool > would allow the reader to easily find the source file that contains > the definition of that function.
Pushed, and back-patched, like that. Best regards, Etsuro Fujita