On Thu, Nov 16, 2023 at 3:48 AM Peter Smith <smithpb2...@gmail.com> wrote: > > ~ > > SUGGESTION (#1a and #1b) > > ereport(log_replication_commands ? LOG : DEBUG1, > errmsg(SlotIsLogical(s) > ? "acquired logical replication slot \"%s\"" > : "acquired physical replication slot \"%s\"", > NameStr(s->data.name))); > > ~~~ >
Personally, I prefer the way Bharath had in his patch. Did you see any preferred way in the existing code? -- With Regards, Amit Kapila.