> On 30 Jul 2020, at 14:11, Robert Haas <robertmh...@gmail.com> wrote: > > On Mon, Jul 20, 2020 at 3:47 PM Robert Haas <robertmh...@gmail.com> wrote: >> But I also agree that what pg_start_backup() was doing before v13 was >> wrong; that's why I committed >> 303640199d0436c5e7acdf50b837a027b5726594. The only reason I didn't >> back-patch it is because the consequences are so minor I didn't think >> it was worth worrying about. We could, though. I'd be somewhat >> inclined to both do that and also change LLVM to use on_proc_exit() in >> master, but I don't feel super-strongly about it. > > Unless somebody complains pretty soon, I'm going to go ahead and do > what is described above.
When backpatching 9dce22033d5d I ran into this in v13 and below, since it needs llvm_shutdown to happen via on_proc_exit in order for all llvm_release_context calls to have finished. Unless anyone objects I will backpatch bab150045bd97 to v12 and v13 as part of my backpatch. -- Daniel Gustafsson