Hi,

I read the V6 patch and found something needs to be improved.

Prepared transactions should also be documented.
         A value of zero (the default) disables the timeout.
+        This timeout is not applied to prepared transactions. Only transactions
+        with user connections are affected.

Missing 'time'.
-                       gettext_noop("Sets the maximum allowed in a 
transaction."),
+                       gettext_noop("Sets the maximum allowed time in a 
transaction."),

16 is already released. It's 17 now.
-       if (AH->remoteVersion >= 160000)
+       if (AH->remoteVersion >= 170000)
                ExecuteSqlStatement(AH, "SET transaction_timeout = 0");

And I test the V6 patch and it works as expected.

--
Yuhang Qiu

Reply via email to