Hi Thomas, > On Fri, Jun 15, 2018 at 8:42 PM, Antonin Houska <a...@cybertec.at> wrote: >> Tatsuo Ishii <is...@sraoss.co.jp> wrote: >> >>> The changes were made by this commit to add infrastructure for sharing >>> temporary files between backends, according to the author (Thomas >>> Munro). >>> >>> https://git.postgresql.org/pg/commitdiff/dc6c4c9dc2a111519b76b22daaaac86c5608223b >>> >>> Your proposal looks reasonable but I would like to hear from Thomas's >>> opinion as well. >> >> o.k. He can actually have different feeling about details, e.g. if a new >> function makeBufFileCommon() should be introduced or if makeBufFile() should >> do the common settings. In the latter case, BufFileCreateTemp() would have to >> do more work than it does now. > > Thanks for finding these accidental duplications, and to Ishii-san for > committing the fix. Oops. > > +1 for this refactoring.
Thanks for confirming. I will go ahead commit/push the patch. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
