Hi,

We fairly regularly have commits breaking the generation of INSTALL. IIRC we
recently discussed building it locally unconditionally, but I couldn't
immediately find that discussion.  Until then, I think we should at least
build it in CI so that cfbot can warn.

Greetings,

Andres Freund
>From 550cf97f0f5d260467583ddf8cd27a36bf03f2ee Mon Sep 17 00:00:00 2001
From: Andres Freund <and...@anarazel.de>
Date: Wed, 20 Dec 2023 03:44:44 -0800
Subject: [PATCH v1] ci: Build INSTALL, it frequently breaks

Author:
Reviewed-By:
Discussion: https://postgr.es/m/
Backpatch:
---
 .cirrus.tasks.yml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/.cirrus.tasks.yml b/.cirrus.tasks.yml
index e137769850d..244e237e9ce 100644
--- a/.cirrus.tasks.yml
+++ b/.cirrus.tasks.yml
@@ -742,6 +742,9 @@ task:
 
   ###
   # Verify docs can be built
+  #
+  # Build the normal docs as well as INSTALL, as the latter is easy to break
+  # via links that cannot be resolved.
   ###
   # XXX: Only do this if there have been changes in doc/ since last build
   always:
@@ -752,7 +755,8 @@ task:
         CXX="ccache g++" \
         CLANG="ccache clang"
       make -s -j${BUILD_JOBS} clean
-      time make -s -j${BUILD_JOBS} -C doc
+      time make -s -j${BUILD_JOBS} -C doc all INSTALL
+
 
   ###
   # Verify headerscheck / cpluspluscheck succeed
-- 
2.41.0.rc2

Reply via email to