On 06/15/2018 02:40 PM, John Naylor wrote: > On 2/19/18, Joe Conway <m...@joeconway.com> wrote: >> The attached does exactly this. Gives all system tables toast tables >> except pg_class, pg_attribute, and pg_index, and includes cat version >> bump and regression test in misc_sanity. >> >> Any further discussion, comments, complaints? > > Hi Joe, > There's been a little bit-rot with duplicate OIDs and the regression > test. The first attached patch fixes that (applies on top of yours).
Not surprising -- thanks for the update. > It occurred to be that we could go further and create most toast > tables automatically by taking advantage of the fact that the toast > creation function is a no-op if there are no varlena attributes. The > second patch (applies on top of the first) demonstrates a setup where > only shared and bootstrap catalogs need to have toast declarations > specified manually with fixed OIDs. It's possible this way is more > fragile, though. Hmmm, I'll have a look. Thanks! Joe -- Crunchy Data - http://crunchydata.com PostgreSQL Support for Secure Enterprises Consulting, Training, & Open Source Development
