On Mon, 7 Aug 2023 at 19:25, Sandro Santilli <s...@kbt.io> wrote: > > On Tue, Aug 01, 2023 at 08:24:15PM +0200, Daniel Gustafsson wrote: > > > On 28 Jun 2023, at 10:29, Daniel Gustafsson <dan...@yesql.se> wrote: > > > > > >> On 31 May 2023, at 21:07, Sandro Santilli <s...@kbt.io> wrote: > > >> On Thu, Apr 27, 2023 at 12:49:57PM +0200, Sandro Santilli wrote: > > > > > >>> I'm happy to bring back the control-file switch if there's an > > >>> agreement about that. > > >> > > >> I'm attaching an up-to-date version of the patch with the control-file > > >> switch back in, so there's an explicit choice by extension developers. > > > > > > This version fails the extension test since the comment from the .sql > > > file is > > > missing from test_extensions.out. Can you fix that in a rebase such that > > > the > > > CFBot can have a green build of this patch? > > > > With no update to the thread and the patch still not applying I'm marking > > this > > returned with feedback. Please feel free to resubmit to a future CF when > > there > > is a new version of the patch. > > Updated version of the patch is attached, regresses cleanly. > Will try to submit this to future CF from the website, let me know > if I'm doing it wrong.
One of tests has failed in CFBot at [1] with: +++ /tmp/cirrus-ci-build/build/testrun/test_extensions/regress/results/test_extensions.out 2023-12-21 02:24:07.738726000 +0000 @@ -449,17 +449,20 @@ -- Test wildcard based upgrade paths -- CREATE EXTENSION test_ext_wildcard1; +ERROR: extension "test_ext_wildcard1" is not available +DETAIL: Could not open extension control file "/tmp/cirrus-ci-build/build/tmp_install/usr/local/pgsql/share/extension/test_ext_wildcard1.control": No such file or directory. +HINT: The extension must first be installed on the system where PostgreSQL is running. SELECT ext_wildcard1_version(); - ext_wildcard1_version ------------------------ - 1.0 -(1 row) - +ERROR: function ext_wildcard1_version() does not exist +LINE 1: SELECT ext_wildcard1_version(); More details available at [2]. [1] - https://cirrus-ci.com/task/6090742435676160 [2] - https://api.cirrus-ci.com/v1/artifact/task/6090742435676160/testrun/build/testrun/test_extensions/regress/regression.diffs Regards, Vignesh