On Sat, Jan 13, 2024 at 11:09 AM Andrei Lepikhov <a.lepik...@postgrespro.ru> wrote: > On 11/1/2024 18:30, Alexander Korotkov wrote: > > On Tue, Jan 9, 2024 at 1:14 PM Pavel Borisov <pashkin.e...@gmail.com> wrote: > >>> Hmm, I don't see this old code in these patches. Resend 0002-* because > >>> of trailing spaces. > >> > >> > >> AFAIK, cfbot does not seek old versions of patchset parts in previous > >> messages. So for it to run correctly, a new version of the whole patchset > >> should be sent even if most patches are unchanged. > > > > Please, find the revised patchset with some refactoring and comments > > improvement from me. I'll continue looking into this. > The patch looks better, thanks to your refactoring. > I propose additional comments and tests to make the code more > understandable (see attachment). > I intended to look into this part of the code more, but the tests show a > difference between PostgreSQL v.15 and v.16, which causes changes in the > code of this feature.
Makes sense. I've incorporated your changes into the patchset. ------ Regards, Alexander Korotkov
0001-Generalize-common-code-of-adding-sort-befor-20240113.patch
Description: Binary data
0002-Explore-alternative-orderings-of-group-by-p-20240113.patch
Description: Binary data
