Dear Vignesh, Thanks for verifying the fix!
> Your proposal to change the tests in the following order: a) failure > due to the insufficient max_replication_slot b) failure because the > pg_subscription_rel has 'd' state c) successful upgrade. looks good to > me. Right. > I have also verified that your changes fixes the issue as the > successful upgrade is moved to the end and the old cluster is no > longer used after upgrade. Yeah, it is same as my expectation. > One minor suggestion: > There is an extra line break here, this can be removed: > @@ -181,139 +310,5 @@ is($result, qq(1), > "check the data is synced after enabling the subscription for > the table that was in init state" > ); > > -# cleanup > Removed. PSA a new version patch. Best Regards, Hayato Kuroda FUJITSU LIMITED https://www.fujitsu.com/
v2-0001-Fix-testcase.patch
Description: v2-0001-Fix-testcase.patch
