On Wed, Feb 14, 2024 at 7:51 PM Euler Taveira <eu...@eulerto.com> wrote: > > On Wed, Feb 14, 2024, at 8:45 AM, Amit Kapila wrote: > > Now, I am less clear about whether to quote "logical" or not in the > above message. Do you have any suggestions? > > > The possible confusion comes from the fact that the sentence contains "must > be" > in the middle of a comparison expression. For pg_createsubscriber, we are > using > > publisher requires wal_level >= logical > > I suggest to use something like > > slot synchronization requires wal_level >= logical >
This sounds like a better idea but shouldn't we directly use this in 'errmsg' instead of a separate 'errhint'? Also, if change this, then we should make a similar change for other messages in the same function. -- With Regards, Amit Kapila.
