On Wed, Feb 14, 2024 at 5:04 PM torikoshia <torikos...@oss.nttdata.com> wrote: > > [....] let the users know what line numbers are > > containing the errors that COPY ignored something like [1] with a > > simple change like [2]. > > Agreed. > Unlike my patch, it hides the error information(i.e. 22P02: invalid > input syntax for type integer: ), but I feel that it's usually > sufficient to know the row number and column where the error occurred.
Right. > > It not only helps users figure out which rows > > and attributes were malformed, but also helps them redirect them to > > server logs with setting log_min_messages = notice [3]. In the worst > > case scenario, a problem with this one NOTICE per malformed row is > > that it can overload the psql session if all the rows are malformed. > > I'm not sure if this is a big problem, but IMO better than a single > > summary NOTICE message and simpler than writing to tables of users' > > choice. > > Maybe could we do what you suggested for the behavior when 'log' is set > to on_error? My point is that why someone wants just the summary of failures without row and column info especially for bulk loading tasks. I'd suggest doing it independently of 'log' or 'table'. I think we can keep things simple just like the attached patch, and see how this feature will be adopted. I'm sure we can come back and do things like saving to 'log' or 'table' or 'separate_error_file' etc., if we receive any firsthand feedback. Thoughts? -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
v1-0001-Add-detailed-info-when-COPY-skips-soft-errors.patch
Description: Binary data
