On 06/25/2018 12:31 AM, Tomas Vondra wrote: > On 06/24/2018 11:39 PM, Thomas Munro wrote: >> On Sun, Jun 24, 2018 at 2:01 PM, Tomas Vondra >> <tomas.von...@2ndquadrant.com> wrote: >>> Attached is rebased version of this BRIN patch series, fixing mostly the >>> breakage due to 372728b0 (aka initial-catalog-data format changes). As >>> 2018-07 CF is meant for almost-ready patches, this is more a 2018-09 >>> material. But perhaps someone would like to take a look - and I'd have >>> to fix it anyway ... >> >> Hi Tomas, >> >> FYI Windows doesn't like this: >> >> src/backend/access/brin/brin_bloom.c(146): warning C4013: 'round' >> undefined; assuming extern returning int >> [C:\projects\postgresql\postgres.vcxproj] >> >> brin_bloom.obj : error LNK2019: unresolved external symbol round >> referenced in function bloom_init >> [C:\projects\postgresql\postgres.vcxproj] >> > > Thanks, I've noticed the failure before, but was not sure what's the > exact cause. It seems there's still no 'round' on Windows, so I'll > probably fix that by using rint() instead, or something like that. >
OK, here is a version tweaked to use floor()/ceil() instead of round(). Let's see if the Windows machine likes that more. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
0001-Pass-all-keys-to-BRIN-consistent-function-a-20180625.patch.gz
Description: application/gzip
0002-Move-IS-NOT-NULL-checks-to-bringetbitmap-20180625.patch.gz
Description: application/gzip
0003-BRIN-bloom-indexes-20180625.patch.gz
Description: application/gzip
0004-BRIN-multi-range-minmax-indexes-20180625.patch.gz
Description: application/gzip
