> On Mar 16, 2024, at 8:53 AM, Daniel Gustafsson <[email protected]> wrote:
>
>
>>
>> On 15 Mar 2024, at 21:56, Andrew Dunstan <[email protected]> wrote:
>> On Fri, Mar 15, 2024 at 10:15 AM Tom Lane <[email protected]
>> <mailto:[email protected]>> wrote:
>> Daniel Gustafsson <[email protected] <mailto:[email protected]>> writes:
>>> I can't see how refusing to free memory owned and controlled by someone
>>> else,
>>> and throwing an error if attempted, wouldn't be a sound defensive
>>> programming
>>> measure.
>>
>> I think the argument is about what "refusal" looks like.
>> An Assert seems OK to me, but anything based on elog is
>> likely to be problematic, because it'll involve exit()
>> somewhere.
>>
>> Yeah, I agree an Assert seems safest here.
>>
>> I'd like to get this done ASAP so I can rebase my incremental parse
>> patchset. Daniel, do you want to commit it? If not, I can.
>
> Sure, I can commit these patches. It won't be until tomorrow though since I
> prefer to have ample time to monitor the buildfarm, if you are in a bigger
> rush
> than that then feel free to go ahead.
>
tomorrow will be fine, thanks
Cheers
Andrew