Hi, On Wed, Mar 20, 2024 at 08:58:05AM +0530, Amit Kapila wrote: > On Wed, Mar 20, 2024 at 12:49 AM Bharath Rupireddy > <bharath.rupireddyforpostg...@gmail.com> wrote: > > > > > > Following are some open points: > > > > 1. Where to do inactive_timeout invalidation exactly if not the > > checkpointer. > > > > I have suggested to do it at the time of CheckpointReplicationSlots() > and Bertrand suggested to do it whenever we resume using the slot. I > think we should follow both the suggestions.
Agree. I also think that pg_get_replication_slots() would be a good place, so that queries would return the right invalidation status. > > 4. New invalidation mechanisms interaction with slot sync feature. > > > > Yeah, this is important. My initial thoughts are that synced slots > shouldn't be invalidated on the standby due to timeout. +1 Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
