On Mon, Mar 25, 2024 at 4:01 PM Amit Langote <amitlangot...@gmail.com> wrote:
> On Mon, Mar 25, 2024 at 7:25 PM Richard Guo <guofengli...@gmail.com> > wrote: > > On Mon, Mar 25, 2024 at 5:17 PM Amit Langote <amitlangot...@gmail.com> > wrote: > >> I've pushed this now. > >> > >> When updating the commit message, I realized that you had made the > >> right call to divide the the changes around not translating the dummy > >> SpecialJoinInfos into a separate patch. So, I pushed it like that. > > > > > > Sorry I'm late for the party. I noticed that in commit 6190d828cd the > > comment of init_dummy_sjinfo() mentions the non-existing 'rel1' and > > 'rel2', which should be addressed. > > Thanks for catching that. Oops. > Good catch. > > > Also, I think we can make function > > consider_new_or_clause() call init_dummy_sjinfo() to simplify the code a > > bit. > > Indeed. > Thanks for fixing it. -- Best Wishes, Ashutosh Bapat
