On Sat, Mar 23, 2024 at 9:37 AM Tomas Vondra <tomas.von...@enterprisedb.com> wrote: > OK, that makes sense. Here's a patch that should work like this - in > copy_file we check if we need to calculate checksums, and either use the > requested copy method, or fall back to the block-by-block copy.
+ Use efficient file cloning (also known as <quote>reflinks</quote> on + some systems) instead of copying files to the new cluster. This can new cluster -> output directory I think your version kind of messes up the debug logging. In my version, every call to copy_file() would emit either "would copy \"%s\" to \"%s\" using strategy %s" and "copying \"%s\" to \"%s\" using strategy %s". In your version, the dry_run mode emits a string similar to the former, but creates separate translatable strings for each copy method instead of using the same one with a different value of %s. In non-dry-run mode, I think your version loses the debug logging altogether. -- Robert Haas EDB: http://www.enterprisedb.com
