On Mon, Mar 25, 2024 at 11:08:39AM -0400, Tom Lane wrote: > * The magic constants (crossover list length and bloom filter size) > need some testing to see if there are better values. They should > probably be made into named #defines, too. I suspect, with little > proof, that the bloom filter size isn't particularly critical --- but > I know we pulled the crossover of 1000 out of thin air, and I have > no certainty that it's even within an order of magnitude of being a > good choice.
I'll try to construct a couple of tests to see if we can determine a proper order of magnitude. > * Code needs more than zero comments. Yup. > * Is it worth trying to make a subroutine, or at least a macro, > so as not to have 2 copies of the code? I think so. I'll try that in the next version. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
