On Sat, Mar 30, 2024 at 11:05 PM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > On Thu, Mar 28, 2024 at 6:31 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > > That is, > > since the LOG_VERBOSITY option is an enum parameter, it might make > > more sense to require the value, instead of making the value optional. > > For example, the following command could not be obvious for users: > > > > COPY test FROM stdin (ON_ERROR ignore, LOG_VERBOSITY); > > Agreed. Please see the attached v14 patch.
Thank you for updating the patch!
> The LOG_VERBOSITY now needs
> a value to be specified. Note that I've not added any test for this
> case as there seemed to be no such tests so far generating "ERROR:
> <<option>> requires a parameter". I don't mind adding one for
> LOG_VERBOSITY though.
+1
One minor point:
ENCODING '<replaceable class="parameter">encoding_name</replaceable>'
+ LOG_VERBOSITY [ <replaceable class="parameter">mode</replaceable> ]
</synopsis>
'[' and ']' are not necessary because the value is no longer optional.
I've attached the updated patch. I'll push it, barring any objections.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
v15-0001-Add-new-COPY-option-LOG_VERBOSITY.patch
Description: Binary data
