On Wed Apr 3, 2024 at 10:05 AM CDT, Jelte Fennema-Nio wrote:
On Wed, 3 Apr 2024 at 16:55, Tristan Partin <tris...@neon.tech> wrote:
> Removing from the switch statement causes a warning:
>
> > [1/2] Compiling C object src/bin/psql/psql.p/command.c.o
> > ../src/bin/psql/command.c: In function ‘wait_until_connected’:
> > ../src/bin/psql/command.c:3803:17: warning: enumeration value
‘PGRES_POLLING_ACTIVE’ not handled in switch [-Wswitch]
> > 3803 | switch (PQconnectPoll(conn))
> > | ^~~~~~
Ofcourse... fixed now
I think patch 2 makes it worse. The value in -Wswitch is that when new
enum variants are added, the developer knows the locations to update.
Adding a default case makes -Wswitch pointless.
Patch 1 is still good. The comment change in patch 2 is good too!
--
Tristan Partin
Neon (https://neon.tech)
