On 2018-Jun-19, Amit Langote wrote: > In CreateTrigger(), 86f575948c7 did this. > > - values[Anum_pg_trigger_tgisinternal - 1] = BoolGetDatum(isInternal); > + values[Anum_pg_trigger_tgisinternal - 1] = BoolGetDatum(isInternal || > in_partition); > > I'm not sure why it had to be done, but undoing this change doesn't seem > to break any regression tests (neither those added by 86f575948c7 nor of > the partitioned table foreign key commit). Did we really intend to change > the meaning of tginternal like this here?
I'm pretty sure pg_dump breaks if you turn that flag off for triggers in partitions, because pg_dump is going to emit commands to create those triggers, and those fail. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
