On Sun, Apr 7, 2024 at 1:33 PM Nazir Bilal Yavuz <byavu...@gmail.com> wrote: > > Hi, > > On Tue, 2 Apr 2024 at 11:40, Thomas Munro <thomas.mu...@gmail.com> wrote: > > > > I had been planning to commit v14 this morning but got cold feet with > > the BMR-based interface. Heikki didn't like it much, and in the end, > > neither did I. I have now removed it, and it seems much better. No > > other significant changes, just parameter types and inlining details. > > For example: > > > > * read_stream_begin_relation() now takes a Relation, likes its name says > > * StartReadBuffers()'s operation takes smgr and optional rel > > * ReadBuffer_common() takes smgr and optional rel > > Read stream objects can be created only using Relations now. There > could be read stream users which do not have a Relation but > SMgrRelations. So, I created another constructor for the read streams > which use SMgrRelations instead of Relations. Related patch is > attached.
This patch LGTM - Melanie
