On Mon, Apr 8, 2024 at 12:34 AM jian he <jian.universal...@gmail.com> wrote: > > On Sun, Apr 7, 2024 at 9:36 PM Amit Langote <amitlangot...@gmail.com> wrote: > > 0002 needs an expanded commit message but I've run out of energy today. > > >
+/* + * Fetch next row from a JsonTablePlan's path evaluation result and from + * any child nested path(s). + * + * Returns true if the any of the paths (this or the nested) has more rows to + * return. + * + * By fetching the nested path(s)'s rows based on the parent row at each + * level, this essentially joins the rows of different levels. If any level + * has no matching rows, the columns at that level will compute to NULL, + * making it an OUTER join. + */ +static bool +JsonTablePlanScanNextRow(JsonTablePlanState *planstate) "if the any" should be "if any" ? also I think, + If any level + * has no matching rows, the columns at that level will compute to NULL, + * making it an OUTER join. means + If any level rows do not match, the rows at that level will compute to NULL, + making it an OUTER join. other than that, it looks good to me.
