On Wed, 10 Apr 2024, 23:37 Jelte Fennema-Nio, <[email protected]> wrote:
> On Wed, 10 Apr 2024 at 20:21, Kirill Reshke <[email protected]> > wrote: > > Do we need to force Collaction here like in other branches? > > if (PQserverVersion(conn) >= 120000) > > appendPQExpBufferStr(buf, " COLLATE pg_catalog.default"); > > According to the commit and codecomment that introduced the COLLATE, > it was specifically added for correct regex matching (e.g. \w). So I > don't think it's necessary, and I'm pretty sure adding it will cause > the index scan not to be used anymore. > Ok, thanks for the clarification. If all of this is actually true, and patch is really does speedup, maybe we need to state this in the comments? >
