> On 2 Jul 2018, at 14:01, Masahiko Sawada <sawada.m...@gmail.com> wrote:

> Thank you for updating the patch! There are two review comments.

Thanks for reviewing!

> The current select_active_windows() function compares the all fields
> of WindowClause for the sorting but with this patch we compare only
> tleSortGroupRef, sortop and the number of uniqueOrder. I think this
> leads a degradation as follows.

You are right, that was an oversight.  The attached patch takes a stab at
fixing this.

> s/readibility/readability/

Fixed.

cheers ./daniel

Attachment: window_prefix_sort-v4.patch
Description: Binary data

Reply via email to