On Sat, May 25, 2024 at 8:53 PM Justin Pryzby <pry...@telsasoft.com> wrote: > On Fri, May 03, 2024 at 04:32:25PM +0300, Alexander Korotkov wrote: > > On Fri, May 3, 2024 at 4:23 PM Justin Pryzby <pry...@telsasoft.com> wrote: > > > Note that the error that led to "EXCLUDING IDENTITY" is being discused > > > over here: > > > https://www.postgresql.org/message-id/3b8a9dc1-bbc7-0ef5-6863-c432afac7...@gmail.com > > > > > > It's possible that once that's addressed, the exclusion should be > > > removed here, too. > > > > +1 > > Can EXCLUDING IDENTITY be removed now ? > > I wasn't able to find why it was needed - at one point, I think there > was a test case that threw an error, but now when I remove the EXCLUDE, > nothing goes wrong.
Yes, it was broken before [1][2], but now it seems to work. At the same time, I'm not sure if we need to remove the EXCLUDE now. IDENTITY is anyway successfully created when the new partition gets attached. Links. 1. https://www.postgresql.org/message-id/171085360143.2046436.7217841141682511557.p...@coridan.postgresql.org 2. https://www.postgresql.org/message-id/flat/ZiGH0xc1lxJ71ZfB%40pryzbyj2023#297b6aef85cb089abb38e9b1a9a7ffff ------ Regards, Alexander Korotkov Supabase
