On Mon, Jun 10, 2024 at 11:36 AM Nathan Bossart <nathandboss...@gmail.com> wrote: > Hm. Should we measure the actual time spent sleeping, or is a rough > estimate good enough? I believe pg_usleep() might return early (e.g., if > the process is signaled) or late, so this field could end up being > inaccurate, although probably not by much. If we're okay with millisecond > granularity, my first instinct is that what you've proposed is fine, but I > figured I'd bring it up anyway.
I bet you could also sleep for longer than planned, throwing the numbers off in the other direction. I'm always suspicious of this sort of thing. I tend to find nothing gives me the right answer unless I assume that the actual sleep times are randomly and systematically different from the intended sleep times but arbitrarily large amounts. I think we should at least do some testing: if we measure both the intended sleep time and the actual sleep time, how close are they? Does it change if the system is under crushing load (which might elongate sleeps) or if we spam SIGUSR1 against the vacuum process (which might shorten them)? -- Robert Haas EDB: http://www.enterprisedb.com
