On Tue, Jun 4, 2024 at 7:03 PM Amit Langote <amitlangot...@gmail.com> wrote: > On Tue, Jun 4, 2024 at 2:20 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > > Peter Eisentraut <pe...@eisentraut.org> writes: > > > On 02.06.24 21:46, Tom Lane wrote: > > >> If you don't > > >> like our current behavior, then either you have to say that RETURNING > > >> with a length-limited target type is illegal (which is problematic > > >> for the spec, since they have no such type) or that the cast behaves > > >> like an implicit cast, with errors for overlength input (which I find > > >> to be an unintuitive definition for a construct that names the target > > >> type explicitly). > > > > > It asks for the latter behavior, essentially (but it's not defined in > > > terms of casts). It says: > > > > Meh. Who needs consistency? But I guess the answer is to do what was > > suggested earlier and change the code to use COERCE_IMPLICIT_CAST. > > OK, will post a patch to do so in a new thread on -hackers.
Oops, didn't realize that this is already on -hackers. Attached is a patch to use COERCE_IMPLICIT_CAST when the RETURNING type specifies a length limit. Given that this also affects JSON_OBJECT() et al that got added in v16, maybe back-patching is in order but I'd like to hear opinions on that. -- Thanks, Amit Langote
v1-0001-SQL-JSON-Use-implicit-casts-for-RETURNING-type-wi.patch
Description: Binary data
