Re: Failures in constraints regression test, "read only 0 of 8192 bytes"

[Heikki Linnakangas]

On 21/06/2024 02:25, Heikki Linnakangas wrote:

Hmm, looking closer, I think this might be a more appropriate place for
the RelationCloseSmgr() call:

                        /*
                         * If it's a mapped relation, immediately update its 
rd_locator in
                         * case its relfilenumber changed.  We must do this 
during phase 1
                         * in case the relation is consulted during rebuild of 
other
                         * relcache entries in phase 2.  It's safe since 
consulting the
                         * map doesn't involve any access to relcache entries.
                         */
                        if (RelationIsMapped(relation))
                                RelationInitPhysicalAddr(relation);

That's where we change the relfilenumber, before the
RelationClearRelation() call.

Pushed a fix that way.

--
Heikki Linnakangas
Neon (https://neon.tech)