Peter Eisentraut <pe...@eisentraut.org> writes: > On 21.06.24 16:53, Tom Lane wrote: >> Most of libpq gets at strerror_r via SOCK_STRERROR for Windows >> portability. Is that relevant here?
> Looking inside the OpenSSL code, it makes no efforts to translate > between winsock error codes and standard error codes, so I don't think > our workaround/replacement code needs to do that either. Fair enough. > Btw., our source code comments say something like > "ERR_reason_error_string randomly refuses to map system errno values." > The reason it doesn't is exactly that it can't do it while maintaining > thread-safety. Ah. Do you want to improve that comment while you're at it? regards, tom lane