> On 27 Jun 2024, at 06:01, Yugo NAGATA <nag...@sraoss.co.jp> wrote: >> Em dom., 23 de jun. de 2024 às 23:56, Richard Guo <guofengli...@gmail.com> >> escreveu: >>> On Mon, Jun 24, 2024 at 7:51 AM Ranier Vilela <ranier...@gmail.com> wrote:
>>>> memcpy with strlen does not copy the whole string. >>>> strlen returns the exact length of the string, without >>>> the null-termination. >>> >>> I noticed that the two callers of do_pg_backup_start both allocate >>> BackupState with palloc0. Can we rely on this to ensure that the >>> BackupState.name is initialized with null-termination? >>> >> I do not think so. In this case we can, we do that today.. > However, I wonder it is better to use strlcpy without assuming such the good > manner of callers. ..that being said I agree that it seems safer to use strlcpy() here. -- Daniel Gustafsson
