Hi, > The proposed patch looks rather incomplete to me, based on the fact > that this stuff has a lot of inconsistencies with the types used when > manipulating 64b SLRU pages. Some of them are harder to catch as the > variables don't specifically refer to pages. > > So, even after v2, there are two more of these in asyncQueueUsage() > with the two QUEUE_POS_PAGE() for the head and tail positions: > int headPage = QUEUE_POS_PAGE(QUEUE_HEAD); > int tailPage = QUEUE_POS_PAGE(QUEUE_TAIL); > > asyncQueueReadAllNotifications() also has one: > int curpage = QUEUE_POS_PAGE(pos); > > asyncQueueAdvanceTail() declares the following: > int oldtailpage; > int newtailpage; > int boundary; > > AsyncQueueControl.stopPage is an int. > > And that's only for async.c. Alexander K., as the owner of the open > item, are you planning to look at that?
Thanks, Michael. I prepared a corrected patchset. -- Best regards, Aleksander Alekseev
v3-0001-Fix-the-comment-for-SlruCtlData.long_segment_name.patch
Description: Binary data
v3-0002-Use-int64-for-page-numbers-in-clog.c-async.c.patch
Description: Binary data
