Hello Charles, > The second review is coming. Here is my working status so far. 1. > Complete the thrift compact protocol implementation using bytea > interface. 2. Thrift type (binary protocol) is almost done, the only > remaining part is struct encoding and decoding. With the thrift type, > you can express your thrift struct using json, but stored using > thrift bytes. 3. Set up travis CI. 4. better documents. > Here is the repo with all recent changes > (https://github.com/charles-cui/pg_thrift) > Let me know if you have any questions.
Thanks for keeping us informed! Though it seems that the code is a little bit broken at the moment: ``` pg_thrift.c:1313:26: error: too few arguments to function ‘array_create_iterator’ ArrayIterator iter = array_create_iterator(parray, 0); ^~~~~~~~~~~~~~~~~~~~~ In file included from pg_thrift.c:5: .../postgresql-install/include/server/utils/array.h:418:22: note: declared here extern ArrayIterator array_create_iterator(ArrayType *arr, int slice_ndim, ArrayMetaState *mstate); ^~~~~~~~~~~~~~~~~~~~~ ``` -- Best regards, Aleksander Alekseev
