On Mon, Jul 22, 2024 at 9:46 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > > Masahiko Sawada <sawada.m...@gmail.com> writes: > > Looking at dodo's failures, it seems that while it passes > > module-xid_wraparound-check, all failures happened only during > > testmodules-install-check-C. Can we check the server logs written > > during xid_wraparound test in testmodules-install-check-C? > > Oooh, that is indeed an interesting observation. There are enough > examples now that it's hard to dismiss it as chance, but why would > the two runs be different?
During the xid_wraparound test in testmodules-install-check-C two clusters are running at the same time. This fact could make the xid_wraparound test slower by any chance. > > (I agree with the comment that we shouldn't be running this test > twice, but that's a separate matter.) +1 not running it twice. There are test modules that have only TAP tests and are not marked as NO_INSTALLCHECK, for example test_custom_rmgrs. Probably we don't want to run these tests twice too? Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
