On Tue, Jul 23, 2024 at 05:41:18PM -0400, Joseph Koshakow wrote: > On Tue, Jul 23, 2024 at 2:14 AM jian he <[email protected]> wrote: >> On Tue, Jul 23, 2024 at 6:56 AM Joseph Koshakow <[email protected]> wrote: >>> The specific bug that this patch fixes is preventing the following >>> statement: >>> >>> # INSERT INTO arroverflowtest(i[-2147483648:2147483647]) VALUES > ('{1}'); >>> >>> So we may want to add that test back in. >>> >> I agree with you. > > I've updated the patch to add this test back in.
I've committed/back-patched the fix for array_set_slice(). I ended up fiddling with the test cases a bit more because they generate errors that include a platform-dependent value (MaxArraySize). To handle that, I moved the new tests to the section added in commit 18b5851 where VERBOSITY is set to "sqlstate". -- nathan
