On Wed, Jul 24, 2024 at 1:25 AM Nathan Bossart <nathandboss...@gmail.com> wrote: > > On Tue, Jul 23, 2024 at 09:05:05AM +0530, Amit Kapila wrote: > > Right, the other option would be to move it to the place where we call > > check_old_cluster_for_valid_slots(), etc. Initially, it was kept in > > the specific function (get_db_rel_and_slot_infos) as we were > > mainlining the count at the per-database level but now as we are > > changing that I am not sure if calling it from the same place is a > > good idea. But OTOH, it is okay to keep it at the place where we > > retrieve the required information from the old cluster. > > I moved it to where you suggested. > > > One minor point is the comment atop get_subscription_count() still > > refers to the function name as get_db_subscription_count(). > > Oops, fixed. >
LGTM. -- With Regards, Amit Kapila.
