On Tue, 23 Jul 2024 at 11:03, Peter Smith <smithpb2...@gmail.com> wrote: > > Here are some review comments for patch v20240720-0002. > > ====== > 1. Commit message: > > 1a. > The commit message is stale. It is still referring to functions and > views that have been moved to patch 0003.
Modified > 1b. > "ALL SEQUENCES" is not a command. It is a clause of the CREATE > PUBLICATION command. Modified > src/bin/psql/describe.c > > 2. describeOneTableDetails > > Although it's not the fault of this patch, this patch propagates the > confusion of 'result' versus 'res'. Basically, I did not understand > the need for the variable 'result'. There is already a "PGResult > *res", and unless I am mistaken we can just keep re-using that instead > of introducing a 2nd variable having almost the same name and purpose. This is intentional, we cannot clear res as it will be used in many places of printTable like in printTable->print_aligned_text->pg_wcssize which was earlier stored from printTableAddCell calls. The rest of the nitpicks comments were merged. The v20240724 version patch attached at [1] has the changes for the same. [1] - https://www.postgresql.org/message-id/CALDaNm1uncevCSMqo5Nk%3DtqqV_o3KNH_jwp8URiGop_nPC8BTg%40mail.gmail.com Regards, Vignesh
