On Tue, Jul 10, 2018 at 01:16:30AM -0700, Andres Freund wrote: > On 2018-07-10 16:59:07 +0900, Michael Paquier wrote: > > if (moveto < minlsn) > > - { > > - ReplicationSlotRelease(); > > ereport(ERROR, > > (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), > > - errmsg("cannot move slot to %X/%X, minimum is > > %X/%X", > > + errmsg("cannot advance replication slot to > > %X/%X, minimum is %X/%X", > > (uint32) (moveto >> 32), > > (uint32) moveto, > > (uint32) (minlsn >> 32), > > (uint32) minlsn))); > > - } > > If you're touching this, I'd also change the errcode here.
Yep, let's change that as well. If you want to look at that stuff more deeply, please feel free. Otherwise I could always push what I have now. -- Michael
signature.asc
Description: PGP signature