On 11 July 2018 at 09:48, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Wed, Jul 11, 2018 at 8:56 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: >> On Wed, Jul 11, 2018 at 5:59 AM, Alvaro Herrera >> >> >>> Please move the output arguments at the end of argument lists; >> >> make sense. >> >>> also, it >>> would be great if you add commentary about ExecDelete other undocumented >>> arguments (tupleDeleted in particular) while you're in the vicinity. >>> >> >> We already have some commentary in the caller of ExecDelete ("For some >> reason if DELETE didn't happen ..."), but I think it will be clear if >> we can add some comments atop function ExecDelete. I will send the >> updated patch shortly. >> > > Attached, please find an updated patch based on comments by Alvaro. > See, if this looks okay to you guys.
Thanks for the patch. It looks good to me. -Amit Khandekar EnterpriseDB Corporation The Postgres Database Company