Hi Jacob, On Wed, Aug 14, 2024 at 6:19 PM Jacob Champion <jacob.champ...@enterprisedb.com> wrote: > > On Tue, Aug 13, 2024 at 9:07 PM Ashutosh Bapat > <ashutosh.bapat....@gmail.com> wrote: > > > I'm not entirely sure what you mean? src/test should work fine, > > > anything lower than that (say src/test/ssl) does not. > > > > I could run them from src/test/modules/xid_wraparound/. That's desirable. > > On my machine, storing xid_wraparound into PG_TEST_EXTRA at configure > time and running `make check` from the modules/xid_wraparound > directory causes them to be skipped. Setting the environment variable > will continue to work at that directory level, though; my patch > shouldn't change that. > > > What is working now should continue to work even after this change. > > PG_TEST_EXTRA="xyz" make check works right now. > > Fair point, see attached.
If I run export PG_TEST_EXTRA=xid_wraparound; ./configure --prefix=$BuildDir --enable-tap-tests && make -j4 && make -j4 install; unset PG_TEST_EXTRA followed by make -C $XID_MODULE_DIR check where XID_MODULE_DIR=src/test/modules/xid_wraparound - it skips the tests. I thought this was working before. Anyway, now I have written a script to test all the scenarios. You may want to test your patch using the script. It just needs PGDir to set to root directory of code. If there's some other way to setting PG_TEST_EXTRA when running configure, I think it needs to be documented. -- Best Wishes, Ashutosh Bapat
test_pg_test_extra.sh
Description: application/shellscript
