On Wed, Aug 28, 2024 at 8:46 PM Nazir Bilal Yavuz <byavu...@gmail.com> wrote:
>
> Also, I think TEST 110 and 170 do not look correct to me. In the
> current way, we do not pass PG_TEST_EXTRA to the make command.
>
> 110 should be:
> 'cd $XID_MODULE_DIR && PG_TEST_EXTRA=xid_wraparound make check'
> instead of 'PG_TEST_EXTRA=xid_wraparound cd $XID_MODULE_DIR && make
> check'
>
> 170 should be:
> 'cd $XID_MODULE_DIR && PG_TEST_EXTRA="" make check && cd $PGDir'
> instead of 'PG_TEST_EXTRA="" cd $XID_MODULE_DIR && make check && cd
> $PGDir'
>

You are right. Jacob did point that out, but I didn't fix all the
places back then. Here's updated script.

-- 
Best Wishes,
Ashutosh Bapat

Attachment: test_pg_test_extra.sh
Description: application/shellscript

Reply via email to