On Thu, Aug 29, 2024 at 7:31 PM Melih Mutlu <m.melihmu...@gmail.com> wrote: > > Hi Michael, > > Michael Harris <har...@gmail.com>, 23 Ağu 2024 Cum, 13:01 tarihinde şunu > yazdı: >> >> V2 of the patch is attached. > > > Thanks for updating the patch. I have a few more minor feedbacks. > >> -ANALYZE [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] >> [ <replaceable class="parameter">table_and_columns</replaceable> [, ...] ] >> +ANALYZE [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] >> [ [ ONLY ] <replaceable class="parameter">table_and_columns</replaceable> [, >> ...] ] > > > I believe moving "[ ONLY ]" to the definitions of table_and_columns below, as > you did with "[ * ]", might be better to be consistent with other places (see > [1]) > >> + if ((options & VACOPT_VACUUM) && is_partitioned_table && ! >> include_children) > >
I think you are right. ANALYZE [ ( option [, ...] ) ] [ [ ONLY ] table_and_columns [, ...] ] seems not explain commands like: ANALYZE ONLY only_parted(a), ONLY only_parted(b);
