Re: On disable_cost

[Richard Guo]

On Fri, Sep 6, 2024 at 5:00 PM Alexander Lakhin <exclus...@gmail.com> wrote:
> static void
> label_sort_with_costsize(PlannerInfo *root, Sort *plan, double limit_tuples)
> {
> ...
>      cost_sort(&sort_path, root, NIL,
>                lefttree->total_cost,
>                plan->plan.disabled_nodes,
>                lefttree->plan_rows,
>                lefttree->plan_width,
>                0.0,
>                work_mem,
>                limit_tuples);
>
> Given the cost_sort() declaration:
> void
> cost_sort(Path *path, PlannerInfo *root,
>            List *pathkeys, int input_disabled_nodes,
>            Cost input_cost, double tuples, int width,
>            Cost comparison_cost, int sort_mem,
>            double limit_tuples)
>
> Aren't the input_disabled_nodes and input_cost arguments swapped in the
> above call?

Nice catch!  I checked other callers to cost_sort, and they are all
good.

(I'm a little surprised that this does not cause any plan diffs in the
regression tests.)

Thanks
Richard