Bertrand Drouvot <bertranddrouvot...@gmail.com> writes: > While working on the per backend I/O statistics patch ([1]), I noticed that > there is an unnecessary call to TimestampTzGetDatum() in pg_stat_get_io() ( > as the reset_time is already a Datum).
Hmm, TimestampTzGetDatum is not a no-op on 32-bit machines. If you're correct about this, why are our 32-bit BF animals not crashing? Are we failing to test this code? regards, tom lane